Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jupyter-server-proxy for security update. #5807

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

ryanlovett
Copy link
Collaborator

@github-actions github-actions bot added the bash label Jun 17, 2024
@shaneknapp
Copy link
Contributor

thanks @ryanlovett ! we should talk about testing/deployment before any merging takes place. :)

@ryanlovett
Copy link
Collaborator Author

@shaneknapp Sure, what did you have in mind?

@shaneknapp
Copy link
Contributor

@shaneknapp Sure, what did you have in mind?

as discussed in slack, it's a proxy for other apps so i'd make sure everything works. plus it's touching (almost) every hub.

links provided by @ryanlovett regarding the upstream changes:
jupyterhub/jupyter-server-proxy@7abc9dc
jupyterhub/jupyter-server-proxy@23dde35

@ryanlovett ryanlovett merged commit 2f6c030 into berkeley-dsep-infra:staging Jun 17, 2024
22 checks passed
@ryanlovett
Copy link
Collaborator Author

@shaneknapp +1. I've merged, and will post follow-up about testing hubs in this thread.

@ryanlovett
Copy link
Collaborator Author

ryanlovett commented Jun 17, 2024

Successfully tested

  • staging
  • biology-staging
  • datahub-staging
  • eecs-staging
  • ischool-staging
  • publichealth-staging
  • r-staging
  • shiny-staging
  • stat20-staging

/rstudio, /desktop, and /vscode where available.

Used git grep proxy= | grep -v -e syncthing -e server-proxy from deployments to see what hubs are providing what apps.

@ryanlovett
Copy link
Collaborator Author

ryanlovett commented Jun 17, 2024

@shaneknapp I think this is good to merge to prod whenever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants